New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizer tutorial #1244
Optimizer tutorial #1244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about this one over email and it looks good to me. When it's merged, after a day it'll automatically be built and put on the mlpack website, so after that it's probably worth it to take a look at the tutorial and make sure everything rendered/compiled right.
doc/tutorials/tutorials.txt
Outdated
@@ -39,6 +39,7 @@ progress to complex, extensible uses. | |||
- \ref cftutorial | |||
- \ref akfntutorial | |||
- \ref cnetutorial | |||
- \ref optimizertutorial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be better as part of the 'policy class documentation'? Not sure, up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
|
||
@file optimizer.txt | ||
@author Marcus Edel (https://kurg.org) | ||
@brief Tutorial for how to implement a new Optimizer in mlpack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should be Tutorial on
instead of Tutorial for
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either is valid, in my opinion.
@endcode | ||
|
||
Finally, \c separable functions must implement the method \c Shuffle() function, | ||
which shuffles the ordering of the functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
End of sentence punctuation (sorry if I'm being excessively concerned about grammar).
|
||
@code | ||
// Shuffel the ordering of the function. | ||
void Shuffel(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shuffle
instead of Shuffel
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thanks!
double Optimize(FunctionType& function, arma::mat& parameters); | ||
@endcode | ||
|
||
The \c Optimize() method optimize the given function \c function, and stores |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optimizes
instead of optimize
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, thanks.
This is basically a striped-down version of "A generic and fast C++ optimization framework".