Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor build for Windows Tutorial #2039

Closed
wants to merge 13 commits into from
Closed

Appveyor build for Windows Tutorial #2039

wants to merge 13 commits into from

Conversation

sriramsk1999
Copy link
Contributor

Handling #1463

So far, I have created a .vcxproj file using the project config details in the tutorial

Would like to know if I'm on the right track :)

@zoq
Copy link
Member

zoq commented Oct 7, 2019

You are one the right track, let me know if I should clarify anything.

@sriramsk1999
Copy link
Contributor Author

Hey @zoq :)

As far as I understand it, it should happen this way:

  • Add another build script in the appveyor.yml file to compile sample-ml-app.cpp
  • Parse the parameters for the build script from the xml file sample-ml-app.vcxproj

Does that sound right? And if so, do you have any references for how to parse the xml file?
Thanks :)

@zoq
Copy link
Member

zoq commented Oct 8, 2019

Haven't checked, but I think msbuild should be able to read the xml file and compile the project.

@zoq
Copy link
Member

zoq commented Oct 9, 2019

Debugging the windows build can be tedious, what I usually do is download the log and search for "error".

@sriramsk1999
Copy link
Contributor Author

@zoq, do you have any idea why the build is failing? The error in the log is:

error MSB8036: The Windows SDK version 10.0.18362 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [C:\projects\mlpack\dist\win-installer\staging\examples\sample-ml-app\sample-ml-app\sample-ml-app.vcxproj]

But the Windows SDK 10.0.18362 is shown to be pre-installed on both Visual Studio 15 and 17 images over here

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure exactly what the build issue is, but maybe my comment helps. Another option if we can't figure it out is to use CMake to generate the appropriate vcxproj file (that might be a little tedious though).

@@ -149,6 +149,9 @@ build_script:
- ps: >
cp C:\projects\mlpack\src\mlpack\tests\data\german.csv
C:\projects\mlpack\dist\win-installer\staging\examples\sample-ml-app\sample-ml-app\data\
- >
"%MSBUILD%" "C:\projects\mlpack\dist\win-installer\staging\examples\sample-ml-app\sample-ml-app.sln"
/m /verbosity:minimal /nologo /p:BuildInParallel=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using the .appveyor/sample-ml-app.vcxproj file here that you added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using the file in doc/examples because the directory was already copied over into the staging directory. I will try switching directories and see if that changes anything

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it just seemed to me like the .appveyor/ vcxproj is different, so that is probably the one we should use here. (I suppose it's possible we may need to make one for each version of Visual Studio that AppVeyor builds for? I am not sure).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still throws the same error of the Windows SDK not being found. As for separate scripts, I 10.0.18362 seems to be pre-installed on both 2015 and 2017 images of Visual Studio, so I think that being a problem is unlikely.

@mlpack-bot
Copy link

mlpack-bot bot commented Nov 18, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@mlpack-bot mlpack-bot bot added the s: stale label Nov 18, 2019
@sriramsk1999
Copy link
Contributor Author

Closing this in light of #2058

@rcurtin
Copy link
Member

rcurtin commented Nov 18, 2019

@sriramsk1999 right, sounds good, we can maybe use what we learned here to get this working on Azure pipelines. Maybe that will fix the strange issue we encountered here too :)

@sriramsk1999 sriramsk1999 deleted the appveyor branch January 1, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants