Catch test part 2 #2584
Merged
Catch test part 2 #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkac
reviewed
Aug 25, 2020
| #include <boost/test/unit_test.hpp> | ||
| #include "test_tools.hpp" | ||
| #include "catch.hpp" | ||
| #include "test_catch_tools.hpp" |
There was a problem hiding this comment.
Is this include needed here? I couldn't find usage of any function/macro from test_catch_tools.hpp
src/mlpack/tests/io_test.cpp
Outdated
| #include <boost/test/unit_test.hpp> | ||
| #include "test_tools.hpp" | ||
| #include "catch.hpp" | ||
| #include "test_catch_tools.hpp" |
zoq
reviewed
Aug 25, 2020
jeffin143
commented
Aug 29, 2020
Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>
|
Hey @jeffin143, can you merge master in and fix the build? I think then this one is close to ready. 😄 |
… into catch-test-part-2
rcurtin
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Everything looks good to me here. Thanks @jeffin143! The VS15 failure (the C1060) is not something we can do much about, and the VS16 failure is fixed in another PR (I can't remember the number right now).
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
|
Another one in! 👍 I think we are getting close now. :) |
This was referenced Oct 14, 2022
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer : #2523