New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding triplet margin loss function #2762
Conversation
Thanks for opening your first pull request in this repository! Someone will review it when they have a chance. In the mean time, please be sure that you've handled the following things, to make the review process quicker and easier:
Thank you again for your contributions! 👍 |
Added Triplet margin loss function
Replace BOOST_SERIALIZATION_NVP with CEREAL_NVP.
Minor Fix
Thanks @NippunSharma . Added your changes and a few more in the implementation of Boost. Now the build was successful and test cases are also passing. |
src/mlpack/methods/ann/loss_functions/triplet_margin_loss_impl.hpp
Outdated
Show resolved
Hide resolved
Thanks @zoq , made the changes you suggested. Hoping everything else is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more comments from my side, thanks for picking this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second approval provided automatically after 24 hours. 👍
Hello there! Thanks for your contribution. I see that this is your first contribution to mlpack. If you'd like to add your name to the list of contributors in In addition, if you'd like some stickers to put on your laptop, I'd be happy to help get them in the mail for you. Just send an email with your physical mailing address to stickers@mlpack.org, and then one of the mlpack maintainers will put some stickers in an envelope for you. It may take a few weeks to get them, depending on your location. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me, thanks for the contributions 👍
Thanks @shrit for the review. |
@ayushsingh11 There is a conflict in the history file, can you resolve the conflict so I can merge this pull request? |
@shrit resolved the conflict. |
Thanks again for the contribution. |
Hi all, this PR is in reference to issue #2200. I have cherry-picked commits from issue #2208 and added minor changes according to the discussion on it. Please review it and inform if any changes are required.
2 matrices are taken as input :