Added LP pooling layer #2828
Merged
Added LP pooling layer #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoq
reviewed
Feb 5, 2021
Comment on lines
48
to
52
| const size_t kernelWidth, | ||
| const size_t kernelHeight, | ||
| const size_t strideWidth = 1, | ||
| const size_t strideHeight = 1, | ||
| const bool floor = true); |
There was a problem hiding this comment.
The parameter should align with the first one.
| { | ||
| const arma::Mat<eT>& inputArea = input(arma::span(i, i + rStep - 1), | ||
| arma::span(j, j + cStep - 1)); | ||
| size_t sum = arma::pow(arma::accu(arma::pow(inputArea, norm_type)), (norm_type-1) / norm_type); |
There was a problem hiding this comment.
Looks like this exceeds the 80 line character limit.
|
@zoq the build is failing and i am not able to figure it out. |
zoq
reviewed
Feb 7, 2021
| @@ -282,6 +283,7 @@ using LayerTypes = boost::variant< | |||
| LSTM<arma::mat, arma::mat>*, | |||
| MaxPooling<arma::mat, arma::mat>*, | |||
| MeanPooling<arma::mat, arma::mat>*, | |||
| LpPooling<arma::mat, arma::mat>*, | |||
There was a problem hiding this comment.
Can you add the layer to MoreTypes (same file) instead and see if that works, we might run into some limitations here.
There was a problem hiding this comment.
I think it worked.
There was a problem hiding this comment.
Okay, great, once #2777 is ready this is going to be a lot easier.
zoq
approved these changes
Feb 9, 2021
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Co-authored-by: kartikdutt18 <39593019+kartikdutt18@users.noreply.github.com>
|
Thanks again for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LP pooling layer.
https://pytorch.org/docs/stable/generated/torch.nn.LPPool2d.html#torch.nn.LPPool2d