Add functions to modify parameters for LARS #2861
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2857.
The PR adds
Lambda1()
,Lambda2()
,UseCholesky()
, andTolerance()
members so that the parameters of LARS training can be modified after creating the object. The only "trickiness" is that we now must recomputeelasticNet
andlasso
(internal members) when we start training, since the user may have modified thelambda1
orlambda2
values.Should be an easy review, I think. :)