Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add random splitting for numeric features for decision trees. #2883

Merged
merged 36 commits into from
May 9, 2021
Merged

Add random splitting for numeric features for decision trees. #2883

merged 36 commits into from
May 9, 2021

Commits on Mar 19, 2021

  1. Defined the random split class

    @RishabhGarg108
    RishabhGarg108 committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    6cd97a7 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. Added implementation of random split

    @RishabhGarg108
    RishabhGarg108 committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    0ad73bc View commit details
    Browse the repository at this point in the history

  2. Added tests

    @RishabhGarg108
    RishabhGarg108 committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    a140aba View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Make new file for random split.

    @RishabhGarg108
    RishabhGarg108 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    d8ca63f View commit details
    Browse the repository at this point in the history

  2. Changed imports

    @RishabhGarg108
    RishabhGarg108 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    ccebfcb View commit details
    Browse the repository at this point in the history

  3. Use math::Random which essentially does the same thing

    @RishabhGarg108
    RishabhGarg108 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    25ce215 View commit details
    Browse the repository at this point in the history

  4. Fixed typo

    @RishabhGarg108
    RishabhGarg108 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    374cb2d View commit details
    Browse the repository at this point in the history

  5. Add citation.

    @RishabhGarg108
    RishabhGarg108 committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    8d63ae3 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Move citation into class and added newline at EOF

    @RishabhGarg108
    RishabhGarg108 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    f2bc627 View commit details
    Browse the repository at this point in the history

  2. Removed best found gain check, as discussed with @rcurtin

    @RishabhGarg108
    RishabhGarg108 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    ab6ae18 View commit details
    Browse the repository at this point in the history

  3. Removed test where no split was made if there was no gain.

    @RishabhGarg108
    RishabhGarg108 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    4704a25 View commit details
    Browse the repository at this point in the history

  4. Add test for different splits under best and random settings.

    @RishabhGarg108
    RishabhGarg108 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    bf98ea5 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/mlpack/mlpack into random… 

    …-split
    @RishabhGarg108
    RishabhGarg108 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    3c3660f View commit details
    Browse the repository at this point in the history

  6. Add UseBootstrap template parameter to random forest

    @RishabhGarg108
    RishabhGarg108 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    43097c9 View commit details
    Browse the repository at this point in the history

  7. Changed train function to use UseBootstrap

    @RishabhGarg108
    RishabhGarg108 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    1ff5e61 View commit details
    Browse the repository at this point in the history

  8. Removed ElemType from RandomBinaryNumericSplit

    @RishabhGarg108
    RishabhGarg108 committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    c049d49 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Add splitIfBetterGain to RandomBinaryNumericSplit

    @RishabhGarg108
    RishabhGarg108 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    5c3b60e View commit details
    Browse the repository at this point in the history

  2. Shifter UseBootstrap to end of template list

    @RishabhGarg108
    RishabhGarg108 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    fdfdc92 View commit details
    Browse the repository at this point in the history

  3. Add typedef for ExtraTrees

    @RishabhGarg108
    RishabhGarg108 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    6ed9384 View commit details
    Browse the repository at this point in the history

  4. Add test ensuring high accuracy on iris classification task.

    @RishabhGarg108
    RishabhGarg108 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    185d795 View commit details
    Browse the repository at this point in the history

  5. Lined up spacing in ExtraTrees typedef

    @RishabhGarg108
    RishabhGarg108 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    9102ac8 View commit details
    Browse the repository at this point in the history

  6. Removed <random> include from BestBinaryNumericSplit

    @RishabhGarg108
    RishabhGarg108 committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    be8893d View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2021

  1. Reduced min accurary to 91%

    @RishabhGarg108
    RishabhGarg108 committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    8984315 View commit details
    Browse the repository at this point in the history

  2. Added to HISTORY.md

    @RishabhGarg108
    RishabhGarg108 committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    82be58a View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Update HISTORY.md

    @RishabhGarg108
    RishabhGarg108 committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    dd9383d View commit details
    Browse the repository at this point in the history

Commits on May 1, 2021

  1. Add documentation for parameters of NumChildren

    @RishabhGarg108
    RishabhGarg108 committed May 1, 2021
    Configuration menu
    Copy the full SHA
    bff45dc View commit details
    Browse the repository at this point in the history

  2. Add documentation for splitIfBetterGain

    @RishabhGarg108
    RishabhGarg108 committed May 1, 2021
    Configuration menu
    Copy the full SHA
    f4e5bf7 View commit details
    Browse the repository at this point in the history

  3. Fixed dataset name in test file

    @RishabhGarg108
    RishabhGarg108 committed May 1, 2021
    Configuration menu
    Copy the full SHA
    0eefde3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'random-split' of ssh://github.com/RishabhGarg108/mlpack… 

    …-1 into random-split
    @RishabhGarg108
    RishabhGarg108 committed May 1, 2021
    Configuration menu
    Copy the full SHA
    347607d View commit details
    Browse the repository at this point in the history

  5. Changed and to && to fix windows build

    @RishabhGarg108
    RishabhGarg108 committed May 1, 2021
    Configuration menu
    Copy the full SHA
    5aece9b View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Changed Randomised -> Randomized

    @RishabhGarg108
    RishabhGarg108 committed May 3, 2021
    Configuration menu
    Copy the full SHA
    9453469 View commit details
    Browse the repository at this point in the history

  2. Add random_split to CMakeLists.txt

    @RishabhGarg108
    RishabhGarg108 committed May 3, 2021
    Configuration menu
    Copy the full SHA
    27227f5 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Reverted unnecessary bracket changes

    @RishabhGarg108
    RishabhGarg108 committed May 7, 2021
    Configuration menu
    Copy the full SHA
    0cb6a13 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>
    @RishabhGarg108 @zoq
    RishabhGarg108 and zoq committed May 9, 2021
    Configuration menu
    Copy the full SHA
    0475778 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into random-split

    @RishabhGarg108
    RishabhGarg108 committed May 9, 2021
    Configuration menu
    Copy the full SHA
    b2a5fe6 View commit details
    Browse the repository at this point in the history

  3. Update HISTORY.md

    @RishabhGarg108
    RishabhGarg108 committed May 9, 2021
    Configuration menu
    Copy the full SHA
    2a6152d View commit details
    Browse the repository at this point in the history