Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable autodownload by default #2953
Disable autodownload by default #2953
Changes from 11 commits
a6de026
ce4ac37
228d8bb
c64f338
453df1d
a5cbc72
d9f995f
781e146
6692049
d5ad6a3
e4b328e
1d10f4a
4d19b40
1267024
2229767
fce8b6b
bea7057
a195608
9f54a4b
daaea02
c01f61f
3e21add
a59f1f4
45a67d0
612b0ab
98e7467
24edc54
379b03e
6dc9c7c
3ee6afa
71924f8
681e4ea
f316e2d
435bfad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you change
\include
to\tmp\include
forARMADILLO_INCLUDE_DIR
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe you can just leave
ARMADILLO_LIBRARY
out?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of a negative option here can be confusing -- using "ON" to actually disable something.
For ease of understanding (and easier maintenance) it's generally best to have a simple on/off for a given functionality. I recommend to change the option to
ENABLE_DOWNLOADS
or more accuratelyDOWNLOAD_DEPENDENCIES
.Using "ON" would then clearly mean to enable downloading the dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, this would be a nice improvement. 👍