Added copy and move constructors for AdaptiveMaxPooling #3173
Conversation
There was a problem hiding this comment.
Thanks for the PR! You can take help from #3128. Also, adding a test example so that it will be easier to debug if there's an issue with the implementation. You can take help from https://github.com/mlpack/mlpack/pull/3136/files
| AdaptiveMaxPooling(const AdaptiveMaxPooling& pooling); | ||
|
|
||
| //Move constructor | ||
| AdaptiveMaxPooling(AdaptiveMaxPooling&& pooling); |
There was a problem hiding this comment.
You can create an assignment operator for both copy and move constructors as you can see in other examples.
|
Hi ! Thanks for the PR. |
|
I will try another issue instead, thanks a lot for your replies. |
|
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍 |
|
Since #2777 was merged, I think that this is not applicable anymore. Sorry that this did not end up getting merged. But thank you nonetheless for putting in the effort! |
No description provided.