Update README.md #3281
Merged
Update README.md #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| <h2 align="center"> | |||
| <a href="http://mlpack.org"><img | |||
| src="https://cdn.rawgit.com/mlpack/mlpack.org/e7d36ed8/mlpack-black.svg" style="background-color:rgba(0,0,0,0);" height=230 alt="mlpack: a fast, flexible machine learning library"></a> | |||
There was a problem hiding this comment.
@shrit the alt string should also be changed accordingly
README.md
Outdated
| @@ -1,7 +1,7 @@ | |||
| <h2 align="center"> | |||
| <a href="http://mlpack.org"><img | |||
| src="https://cdn.rawgit.com/mlpack/mlpack.org/e7d36ed8/mlpack-black.svg" style="background-color:rgba(0,0,0,0);" height=230 alt="mlpack: a fast, flexible machine learning library"></a> | |||
| <br>a fast, flexible machine learning library<br> | |||
| <br>a fast, flexible header-only machine learning library<br> | |||
There was a problem hiding this comment.
@shrit maybe simplify to "header-only machine learning library".
too many qualifiers can muddle the main message
There was a problem hiding this comment.
Yeah, that seems fine to me, fast, header-only gets the idea across still, in my opinion. 👍
There was a problem hiding this comment.
Indeed that can work as well
zoq
reviewed
Oct 4, 2022
| @@ -1,7 +1,7 @@ | |||
| <h2 align="center"> | |||
| <a href="http://mlpack.org"><img | |||
| src="https://cdn.rawgit.com/mlpack/mlpack.org/e7d36ed8/mlpack-black.svg" style="background-color:rgba(0,0,0,0);" height=230 alt="mlpack: a fast, flexible machine learning library"></a> | |||
| <br>a fast, flexible machine learning library<br> | |||
| <br>a fast, header-only machine learning library<br> | |||
There was a problem hiding this comment.
What is the reason to remove the flexible part? I still think mlpack is flexible.
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.