Catch all exceptions in Julia #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrit
approved these changes
Nov 12, 2022
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, when running an mlpack binding from Julia, we want to catch all exceptions, instead of crashing.
A typo in the existing code meant we only caught
std::runtime_errors instead of any exception. So, easy fix: just catchstd::exceptioninstead.Note that for these to be caught correctly, the Julia bindings should not be compiled with
-DARMA_NO_DEBUG, otherwise the out-of-bounds checks will not be done and may cause invalid memory accesses and segfaults, instead of throwing exceptions.