Use -framework Accelerate on OS X. #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradsnicta
approved these changes
Nov 13, 2022
|
Good idea for several reasons. While OpenBLAS is often assumed to be faster on deprecated x86-64 macs, the situation doesn't appear to be the same on newer macs with M1 and M2 CPUs. Apparently the new M apple processors have hidden functionality to accelerate matrix multiplication, which is likely used by veclib (part of the Accelerate framework?). The OpenBLAS project is (so far) not willing to use processor instructions that are not officially documented: OpenMathLib/OpenBLAS#3789 |
![mlpack-bot[bot]](https://avatars.githubusercontent.com/in/23934?s=60&v=4){kind=small}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies CMake to link against the Accelerate framework on OS X, using
-framework Accelerate. This is a port of what Armadillo's CMake configuration already does.The Accelerate framework is Apple's BLAS/LAPACK replacement; if it's available, Armadillo will use it, and with this patch, mlpack will use it too.