Correctly link with -lm
in Python bindings
#3309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain situations (OS X is where I encountered it), one of the libraries in the CMake
MLPACK_LIBRARIES
variable is"m"
, to indicate that we should link with-lm
. However, every other library inMLPACK_LIBRARIES
is a direct path to a library to link against. This means that when compiling Cython bindings, we get command-lines likebut that
m
isn't very helpful---it needs to be-lm
. This patch adds a workaround specifically for this case to the Cython build configuration.