Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preprocess.hpp include and add missing includes to mlpack.hpp #3374

Merged
merged 4 commits into from Jan 26, 2023
Merged

Add preprocess.hpp include and add missing includes to mlpack.hpp #3374

merged 4 commits into from Jan 26, 2023

Conversation

rcurtin
Copy link
Member

@rcurtin rcurtin commented Jan 24, 2023

Thanks @Aadi-Raj for pointing this one out. A couple simple fixes:

  • A few files were not included in mlpack.hpp. I added them.
  • The file preprocess/preprocess.hpp didn't exist. I added that.
  • A few methods in ScalingModel weren't marked inline, but they need to be since they are not templated.

@rcurtin rcurtin mentioned this pull request Jan 24, 2023
Closed
@rcurtin rcurtin merged commit 870b83a into mlpack:master Jan 26, 2023
@rcurtin rcurtin deleted the include-fixes branch January 26, 2023 01:04
@rcurtin rcurtin mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoq zoq zoq approved these changes

@conradsnicta conradsnicta conradsnicta approved these changes

Assignees
No one assigned
Labels
c: methods t: bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rcurtin @zoq @conradsnicta