Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid deprecation warnings in Armadillo 11.4.4+ #3405

Merged
merged 3 commits into from Feb 10, 2023

Conversation

conradsnicta
Copy link
Contributor

Change all instances of .quiet_save() to .save(). This is to avoid compile-time deprecation warnings.

The functions .quiet_save() and .quiet_load() have been deprecated since Armadillo 11.4.4.

Since Armadillo 10.4, the default degree of warning messages has been reduced, so that failed saving / loading no longer emits warnings.

(The warning level can be manually changed via the ARMA_WARN_LEVEL option).

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. 👍

Copy link
Member

@shrit shrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants