New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated hard_tanh and added to layer_types #3454
Conversation
Hey @mrdaybird , I would suggest you to refer this #2777 as you are missing some adaptions like copy and move function, openmp, virtual distructor, etc. :) |
yeah you are right, I kind of missed that. Thank you for pointing that out! |
@rcurtin Can you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Want to add a note to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second approval provided automatically after 24 hours. 👍
Related to #2777