Fix include ordering for LinearRegression
#3541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3540 @kiner-shah pointed out that it is possible to create a circular include loop! I was surprised by this, but the reason is that the
RegressionDistribution
class (insrc/mlpack/core/dists/
) depends on theLinearRegression
class (insrc/mlpack/methods/
). This is the only situation where something incore/
includes something inmethods/
, and as a result, if you just happen to only includelinear_regression.hpp
, you get a problem.Anyway, one solution is to have
linear_regression.hpp
only includemlpack/prereqs.hpp
(which does not include thedists/
), and then includemlpack/core.hpp
afterLinearRegression
is defined.After this PR, the following slightly more complex example compiles: