Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix L1 regularization in case where weight is zero #3545

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Fix L1 regularization in case where weight is zero #3545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b27f25
Fix L1 regularization in case where weight is zero
Oct 18, 2023
01e2c32
Update HISTORY.md
akropp Oct 19, 2023
60cffa2
Update HISTORY.md
rcurtin Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
###### ????-??-??
* Fix include ordering issue for `LinearRegression` (#3541).

* Fix L1 regularization in case where weight is zero (#3545).

### mlpack 4.2.1
###### 2023-09-05
* Reinforcement Learning: Gaussian noise (#3515).
Expand Down
2 changes: 1 addition & 1 deletion src/mlpack/methods/ann/regularizer/lregularizer_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ template<>
template<typename MatType>
void LRegularizer<1>::Evaluate(const MatType& weight, MatType& gradient)
{
gradient += arma::vectorise(factor * weight / arma::abs(weight));
gradient += arma::vectorise(factor * arma::sign(weight));
}

// L2-Regularizer specializations.
Expand Down