Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS for auto-downloaded dependencies #3550

Merged
merged 4 commits into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ else()
message(FATAL_ERROR "Can not find BLAS or LAPACK! These are required for Armadillo. Please install one of them---or install Armadillo---before installing mlpack.")
endif()
endif()
get_deps(http://files.mlpack.org/armadillo-10.3.0.tar.gz armadillo armadillo-10.3.0.tar.gz)
get_deps(https://files.mlpack.org/armadillo-10.3.0.tar.gz armadillo armadillo-10.3.0.tar.gz)
conradsnicta marked this conversation as resolved.
Show resolved Hide resolved
set(ARMADILLO_INCLUDE_DIR ${GENERIC_INCLUDE_DIR})
find_package(Armadillo REQUIRED)
endif()
Expand All @@ -313,7 +313,7 @@ if (NOT DOWNLOAD_DEPENDENCIES)
else()
find_package(StbImage)
if (NOT STB_IMAGE_FOUND)
get_deps(http://mlpack.org/files/stb.tar.gz stb stb.tar.gz)
get_deps(https://mlpack.org/files/stb.tar.gz stb stb.tar.gz)
set(STB_IMAGE_INCLUDE_DIR ${GENERIC_INCLUDE_DIR})
find_package(StbImage REQUIRED)
endif()
Expand All @@ -339,7 +339,7 @@ if (NOT DOWNLOAD_DEPENDENCIES)
else()
find_package(Ensmallen "${ENSMALLEN_VERSION}")
if (NOT ENSMALLEN_FOUND)
get_deps(http://www.ensmallen.org/files/ensmallen-latest.tar.gz ensmallen ensmallen-latest.tar.gz)
get_deps(https://www.ensmallen.org/files/ensmallen-latest.tar.gz ensmallen ensmallen-latest.tar.gz)
set(ENSMALLEN_INCLUDE_DIR ${GENERIC_INCLUDE_DIR})
find_package(Ensmallen REQUIRED)
endif()
Expand Down
4 changes: 3 additions & 1 deletion HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,16 @@

* Add `ClassProbabilities()` member to `DecisionTree` so that the internal
details of trees can be more easily inspected (#3511).

* Bipolar sigmoid activation function added and invertible functions
fixed (#3506).

* Add auto-configured `mlpack/config.hpp` to contain configuration details of
mlpack that are required at compile time. STB detection is now done in this
file with the `MLPACK_HAS_STB` macro (#3519).

* Use HTTPS for all auto-downloaded dependencies (#3550).

### mlpack 4.2.0
###### 2023-06-14
* Adapt C_ReLU, ReLU6, FlexibleReLU layer for new neural network API (#3445).
Expand Down