Added Size checks for logistic regression #3658
Closed
+7
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViswanathBalla22
changed the title
zoq
reviewed
Mar 21, 2024
| @@ -30,13 +31,14 @@ LogisticRegressionFunction<MatType>::LogisticRegressionFunction( | |||
| false)), | |||
| lambda(lambda) | |||
| { | |||
| // Sanity check. | |||
| if (responses.n_elem != predictors.n_cols) | |||
| if (!util::CheckSameSizes(predictors.n_cols, responses.n_elem, | |||
There was a problem hiding this comment.
CheckSameSizes has no return value:
https://github.com/mlpack/mlpack/blob/master/src/mlpack/core/util/size_checks.hpp#L35
So you have to use it outside of the if statement.
|
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to solve some tasks in issue #2820 with help of #2370 as discussed in the comments.
Tasks done :
Added size checks using CheckSameSizes and CheckSameDimensionality utilities in logistic regression