move matrix_completion_impl.hpp to matrix_completion.cpp #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid a possible multiple definitions issue at link time
|
This addresses #381 |
|
I thought I gave you permissions to push to mlpack/mlpack, but I'm happy to merge these things in either way. :) |
rcurtin
added a commit
that referenced
this pull request
Jan 13, 2015
move matrix_completion_impl.hpp to matrix_completion.cpp
rcurtin
added a commit
that referenced
this pull request
Mar 6, 2015
move matrix_completion_impl.hpp to matrix_completion.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid a possible multiple definitions issue at link time