kmeans: small fix with inf variance #481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
There seems to be no check on the cluster size when it's decreased, yet it's used afterwards to update the variance. So, if the cluster size reaches zero, the variance is infinity. As a result, the cluster gets chosen in the next iteration and causes access to
furthestPoint == data.n_cols
, which is rather sad.I simply added the same condition as in
Precalculate
.