add move constructor and move assignment for ann modules #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow that was fast, thanks for the first modifications. Should I merge the modification as it is or should I wait for more changes? It's up to you, pick the one that is easier for you. If it's easier for you to open a new pull request, I go and merge the pull request. |
You could merge it now if you think it is ok. |
| } // namespace ann | ||
| } // namespace mlpack | ||
| }; // namespace ann | ||
| }; // namespace mlpack |
There was a problem hiding this comment.
This is pedantic (literally), but if you compile with -pedantic the extra semicolon produces a warning. So I've been trying to avoid doing that. :)
zoq
added a commit
that referenced
this pull request
Dec 31, 2015
Add move constructor and move assignment for ann modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement move constructor and move assignment for ann modues.
By now only implement for linear_layer.hpp, base_layer.hpp and bias_layer.hpp, will implement for another classes step by step