Fix classification error #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change "invVar" to "variance" matrix when calculating testProbs. By using "invVar" you have variances product in numenator, but it needs to be in denominator. In addition there was potential problem with accuracy when calculate exponents and then calculate logarithm. I fixed it too.
|
I like the change of calculating the exponents in logspace, thanks. You're right about the problem, too; it looks like the test cases did not catch this. Would you like me to add your name to the list of contributors? |
|
Thanx for answer. And yes, it would be very nice from your side to add me to list of contributors. My name is Pavel Zhigulin. |
|
Great, added in d3b7d2f. Thanks again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change "invVar" to "variance" matrix when calculating testProbs.
By using "invVar" you have variances product in numenator, but it needs to be in denominator.
In addition there was potential problem with accuracy when calculate exponents and then calculate logarithm.
I fixed it too.