Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge_boxes: feature extraction #679

Merged
merged 3 commits into from Jun 7, 2016
Merged

edge_boxes: feature extraction #679

merged 3 commits into from Jun 7, 2016

Conversation

nilayjain
Copy link
Member

Feature extraction part of edge_boxes algorithm.

@nilayjain
Copy link
Member Author

can armadillo be upgraded to a new version or should i add a new function for ind2sub ?

@stereomatchingkiss
Copy link
Contributor

Thanks, this class is quite hard to implement. Will study your codes on next Thursday(9/6/2016).

@rcurtin
Copy link
Member

rcurtin commented Jun 5, 2016

ind2sub() and sub2ind() came in Armadillo 6.400, which in my opinion is too recent. Ubuntu 14.04 (which many people are still using) still has Armadillo 4.200. I think the better solution is just to backport ind2sub() and sub2ind() into src/mlpack/core/arma_extend/. Basically this comes down to using preprocessor macros to detect the version and then including the function if the version is too old. Take a look at src/mlpack/core/arma_extend/typedef.hpp to see an idea of what I mean (also src/mlpack/core/arma_extend/arma_extend.hpp).

@zoq
Copy link
Member

zoq commented Jun 6, 2016

Before I take a closer look at the code, it would be great if you could write some tests. This way, we can make sure everything works as expected even if we change something over time.

@nilayjain
Copy link
Member Author

Seems like a good Idea, I will go ahead and do that.

@rcurtin rcurtin merged commit dec9ab0 into mlpack:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants