Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PCA class: able to use different decomposition techniques (exact, randomized, QUIC SVD). #716

Closed
wants to merge 31 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
4727298
Fix explicitly specialized template issue.
zoq Jun 2, 2016
05b36fc
Merge remote-tracking branch 'upstream/master'
zoq Jun 5, 2016
00e867f
edge_boxes: feature extraction
nilayjain Jun 5, 2016
c8d5766
Properly resetting auxBound. Start using a Reset() method, to avoid f…
MarcosPividori Jun 3, 2016
5149efd
backported ind2sub and sub2ind
nilayjain Jun 6, 2016
61e63b9
backported ind2sub and sub2ind
nilayjain Jun 6, 2016
5f01b84
Revert "edge_boxes: feature extraction"
nilayjain Jun 6, 2016
8907d5a
backported sub2ind & ind2sub
nilayjain Jun 6, 2016
b8da5c6
fix doc tutorial
keon Jun 7, 2016
0d6d3af
Use appveyor cache (nuget and armadillo).
zoq Jun 7, 2016
45e8cd6
fix typo
keon Jun 7, 2016
01e699c
added test for ind2sub and sub2ind
nilayjain Jun 7, 2016
7e8abed
Minor style fixes for ind2sub() test.
rcurtin Jun 7, 2016
7bbd897
Add new contributors.
rcurtin Jun 7, 2016
29fcf0a
Try debugging symbols for AppVeyor build to see if it is faster.
rcurtin Jun 7, 2016
cbbd671
Merge remote-tracking branch 'upstream/master'
zoq Jun 14, 2016
ec0a6d5
Add QUIC-SVD singular values test.
zoq Jul 4, 2016
6aedf56
Remove implementation from header file to avoid duplicate symbol error.
zoq Jul 4, 2016
570a3d8
Add randomized SVD method.
zoq Jul 4, 2016
907461f
Add randomized SVd test suite.
zoq Jul 4, 2016
861fe30
Add exact, randomized and QUIC SVD decomposition policies; meant to b…
zoq Jul 4, 2016
9101a6f
Refactor PCA class; able to use different decomposition methods.
zoq Jul 4, 2016
ee7ff36
Merge remote-tracking branch 'upstream/master'
zoq Jul 4, 2016
10d435f
Merge with master.
zoq Jul 4, 2016
081428e
Fix merge conflict.
zoq Jul 4, 2016
43744c5
Remove unused header guard.
zoq Jul 4, 2016
260a48e
Update boost test header.
zoq Jul 4, 2016
1d675d4
Do not split if numColumns < 3.
zoq Jul 4, 2016
080d198
Use the correct svd method name and parameter name for the centered d…
zoq Jul 5, 2016
1c0192f
Minor style changes.
zoq Jul 5, 2016
1127e61
Introduce compatibility by changing PCA to PCAType.
zoq Jul 5, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mlpack/core/tree/cosine_tree/cosine_tree.cpp
Expand Up @@ -277,8 +277,8 @@ void CosineTree::ConstructBasis(CosineNodeQueue& treeQueue)

void CosineTree::CosineNodeSplit()
{
// //! If less than two nodes, splitting does not make sense.
// if (numColumns < 3) return;
//! If less than two nodes, splitting does not make sense.
if (numColumns < 3) return;

//! Calculate cosines with respect to the splitting point.
arma::vec cosines;
Expand Down