Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use move semantics to set a given reference tree in NeighborSearch class. #765

Merged
merged 24 commits into from Aug 30, 2016
Merged

Use move semantics to set a given reference tree in NeighborSearch class. #765

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d585b86
Documentation details.
MarcosPividori Jul 28, 2016
998daa1
Add move constructor for cover tree.
MarcosPividori Jul 28, 2016
260f711
Add support for rvalue references when setting a given reference tree in
MarcosPividori Jul 28, 2016
fe0039b
Update knn test to use rvalue references.
MarcosPividori Jul 28, 2016
22f3a1f
Update kfn test to use rvalue references.
MarcosPividori Jul 28, 2016
4a1fb51
Fix error in BinarySearchTree move constructor.
MarcosPividori Aug 1, 2016
cccf0aa
Add a new TreeTraits's member: HasDuplicatedPoints.
MarcosPividori Aug 1, 2016
53476a6
Add support for copying the reference tree in NeighborSearch class.
MarcosPividori Aug 12, 2016
1753f25
Add DEPRECATED macro.
MarcosPividori Aug 15, 2016
c7a7a6e
Mark constructor and Train() method taking a pointer to the reference…
MarcosPividori Aug 15, 2016
14cf05c
Replace DEPRECATED by mlpack_deprecated.
MarcosPividori Aug 19, 2016
74fd863
Avoid deprecated methods inside NeighborSearch class.
MarcosPividori Aug 19, 2016
16de796
Update tests to use rvalue references.
MarcosPividori Aug 19, 2016
fd14441
Add deprecated flags
MarcosPividori Aug 23, 2016
250bd45
Update constructors taking a reference to the reference tree.
MarcosPividori Aug 23, 2016
d85cd15
Use !oldFromNewReferences.empty() instead of treeOwner to determine
MarcosPividori Aug 23, 2016
5d3fd6f
Fix test for cover trees.
MarcosPividori Aug 23, 2016
2601243
Add method to access to the reference tree.
MarcosPividori Aug 29, 2016
4f5ef3c
Update kmeans implementation to use rvalue references.
MarcosPividori Aug 29, 2016
0317501
Let's use a const reference when copying the reference tree.
MarcosPividori Aug 29, 2016
8bf2e5c
Remove mlpack_deprecated from search mode flags, because it was resul…
MarcosPividori Aug 29, 2016
db16a10
Remove deprecated constructor.
MarcosPividori Aug 29, 2016
0d071af
Add more information on deprecated methods.
MarcosPividori Aug 29, 2016
8062be1
Take a reference instead of a pointer to the query tree.
MarcosPividori Aug 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/mlpack/methods/neighbor_search/neighbor_search.hpp
View file
Open in desktop
Expand Up @@ -467,24 +467,30 @@ class NeighborSearch
size_t Scores() const { return scores; }

//! Access whether or not search is done in naive linear scan mode.
//! Deprecated. Will be removed in mlpack 3.0.0.
//! Deprecated. Will be replaced in mlpack 3.0.0, by a new method:
//! NeighborSearchMode SearchMode().
bool Naive() const { return naive; }
//! Modify whether or not search is done in naive linear scan mode.
//! Deprecated. Will be removed in mlpack 3.0.0.
//! Deprecated. Will be replaced in mlpack 3.0.0, by a new method:
//! NeighborSearchMode& SearchMode().
bool& Naive() { return naive; }

//! Access whether or not search is done in single-tree mode.
//! Deprecated. Will be removed in mlpack 3.0.0.
//! Deprecated. Will be replaced in mlpack 3.0.0, by a new method:
//! NeighborSearchMode SearchMode().
bool SingleMode() const { return singleMode; }
//! Modify whether or not search is done in single-tree mode.
//! Deprecated. Will be removed in mlpack 3.0.0.
//! Deprecated. Will be replaced in mlpack 3.0.0, by a new method:
//! NeighborSearchMode& SearchMode().
bool& SingleMode() { return singleMode; }

//! Access whether or not search is done in greedy mode.
//! Deprecated. Will be removed in mlpack 3.0.0.
//! Deprecated. Will be replaced in mlpack 3.0.0, by a new method:
//! NeighborSearchMode SearchMode().
bool Greedy() const { return greedy; }
//! Modify whether or not search is done in greedy mode.
//! Deprecated. Will be removed in mlpack 3.0.0.
//! Deprecated. Will be replaced in mlpack 3.0.0, by a new method:
//! NeighborSearchMode& SearchMode().
bool& Greedy() { return greedy; }

//! Access the relative error to be considered in approximate search.
Expand Down