Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arma sorting work with SpMat. #808

Closed
wants to merge 3 commits into from

Conversation

thejonan
Copy link
Contributor

@thejonan thejonan commented Nov 1, 2016

A sparse matrix sort capability, added as part of MLPack's extensions to Armadillo lib.

Note: There are not tests added, also - custom type of sorting, etc. Just the core sorting function.

@rcurtin
Copy link
Member

rcurtin commented Dec 5, 2016

Okay, I've opened a PR on your branch (thejonan#1) to add some tests to this. Sorry for the slowness on this, it took a while to find the time.

Before merging this upstream with Armadillo, could I ask you to add a version of sort() that takes in an input matrix and a dimension on which to sort (either column-wise or row-wise), just like arma::sort() for dense matrices?

http://arma.sourceforge.net/docs.html#sort

I already have some simple tests written for that, so you can just uncomment those. After that this will be ready to merge and then I can make the minor changes necessary to submit a patch upstream (I'll CC you on the email when that gets done).

Thanks!

@thejonan
Copy link
Contributor Author

thejonan commented Dec 5, 2016

I knew, that per-dimension sorting will come into discussion :-) I'll take a look at this, but don't promise that I'll be fast.

@rcurtin
Copy link
Member

rcurtin commented Dec 5, 2016

No hurry, whenever you have time is fine. :)

@mlpack-jenkins
Copy link

Can one of the admins verify this patch?

@mlpack-bot
Copy link

mlpack-bot bot commented Feb 18, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@mlpack-bot mlpack-bot bot added the s: stale label Feb 18, 2019
@mlpack-bot mlpack-bot bot closed this Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants