-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added copy constructor, move constructor and copy assignment operator. #826
Merged
Merged
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8dd4845
Added copy constructor, move constructor and copy assignment operator.
s1998 5d5861e
Added tests for copy constructor, move constructor, copy assignment o…
s1998 952211b
Added tests for copy constructor, move constructor, copy assignment o…
s1998 a1a0e3c
Added copy constructor, move constructor, copy assignment operator an…
s1998 a1a1cef
Added copy constrcutor, move constructor, copy assignment operator an…
s1998 4fccbc9
Update dtree_impl.hpp
s1998 89cef13
Update dtree_impl.hpp
s1998 7d1bb44
Update det_test.cpp
s1998 3a3fd60
Update dtree_impl.hpp
s1998 ddbfd81
Updated copy constructor and changed the tests to ensure children are…
s1998 a7ff69c
Updated copy constructor and changed the tests to ensure children are…
s1998 5542ae9
Update copy/move constuctor amd operator.
s1998 2e37a38
Update dtree_impl.hpp
s1998 58cf0d9
Update det_test.cpp
s1998 c9e7fb0
Merge branch 'master' of https://github.com/s1998/mlpack
s1998 f709ad6
Update copy/move constuctor amd operator.
s1998 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point
leftChild
andrightChild
should be invalid pointers; I bet valgrind will call this an invalid memory access and in some cases this test will fail.