cover tree optimization #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… full distance if it is not needed
rcurtin
reviewed
Dec 20, 2016
| typename CoverTree<MetricType, StatisticType, MatType, | ||
| RootPointPolicy>::ElemType | ||
| CoverTree<MetricType, StatisticType, MatType, RootPointPolicy>:: | ||
| MaxDistance(const arma::vec& other, const ElemType bestDistance, bool forOverload) |
There was a problem hiding this comment.
I think the signature is wrong here, should this be MaxDistanceForFast? (same with the other MaxDistance overload)
|
Thanks for the contribution---as soon as we can get this to compile I can test to see what the runtime improvement is. |
|
Can one of the admins verify this patch? |
|
Closing for inactivity---I'd love to see this one work, but I think there is still a good amount of work to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made distance calculations faster in cover trees by not computing the full distance if it is not needed