Initialise "success" variable to fix warnings #840
Conversation
|
Any suggestions why the travis-ci build fails. |
|
Don't worry about the travis failure, it is not related to your fix here. If you can fix the issue I pointed out, I am happy to merge these. Please feel free to add your name to the list of contributors in |
| @@ -43,8 +43,6 @@ size_t RPlusTreeDescentHeuristic::ChooseDescentNode(TreeType* node, | |||
| node->Child(bestIndex).Bound(); | |||
| bound |= node->Dataset().col(point); | |||
|
|
|||
| success = true; | |||
|
|
|||
There was a problem hiding this comment.
The change that you've made means that during this loop, success is not reinitialized to true each iteration. So this introduces a bug.
rishabhkumar296
force-pushed
the
master
branch
from
9140b85
to
def7cb9
Compare
rishabhkumar296
force-pushed
the
master
branch
from
def7cb9
to
b675ac9
Compare
|
I think you force pushed, so I did not see that there was a change. This looks better, thanks for the contribution. If you'd like to add your name to the list of contributors (even though this is a small contribution!) to |
No description provided.