Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve learner and measure table by using js:DataTable #69

Closed
wants to merge 2 commits into from

Conversation

jakob-r
Copy link
Contributor

@jakob-r jakob-r commented Nov 9, 2016

Does not work yet. Probelm seems to be that <script data-main="../mkdocs/js/search.js" src="../mkdocs/js/require.js"></script> breaks something so that DataTable can't be called anymore.
If we put the search script after the tables.js both work but we can not modify it so easily in mkdocs.

note: to test locally you probably need to use a tiny http server otherwise the search does not work anyways.

@pat-s
Copy link
Collaborator

pat-s commented Jun 21, 2018

@jakob-r Is this idea still valid with the new pkgdown approach or even desirable?

@jakob-r
Copy link
Contributor Author

jakob-r commented Jun 22, 2018

Yes. Our table is not perfectly organized. Therefore js:DataTable would still be a nice to have but with all of our PDF stuff I don't know how feasible it is to have output specific stuff. So we can close it unless somebody is really eager to do this kind of stuff.

@pat-s
Copy link
Collaborator

pat-s commented Jun 22, 2018

Ok. Maybe some other tools came up in the meantime as well.
Potentially somebody is interested in the hackathon and then a new issue can be opened.

@pat-s pat-s closed this Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants