getHyperPars.BaseWrapper broken for imputeWrapper?

[giuseppec]

This here works and gives is the hyperparameters

rf = makeLearner("classif.randomForest")
lrn2 = makeFilterWrapper(rf, fw.perc = 0.5, fw.method = "variance")
lrn2$par.vals
# $fw.method
# [1] "variance"
# 
# $fw.perc
# [1] 0.5
getHyperPars(lrn2)
# $fw.method
# [1] "variance"
# 
# $fw.perc
# [1] 0.5

This here is buggy and we get an empty list, no matter which hyperparameter of the imputeWrapper are set:

rf = makeLearner("classif.randomForest")
lrn = makeImputeWrapper(rf, class = imputeMedian(), impute.new.levels = FALSE)
lrn$par.vals # this contains some defaults + the changed hyperparameters
getHyperPars(lrn) # this is an empty list

[giuseppec]

This also happens for makeDummyFeaturesWrapper and makeRemoveConstantFeaturesWrapper. I think this happens because all those wrappers internally use the makePreprocWrapper function without changing the par.set default which is makePreprocWrapper(..., par.set = makeParamSet()). Not sure if feature or bug? Is there a reason why we don't extend the param.set for all those wrappers?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.