Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing filter / featsel methods #2

Open
21 of 29 tasks
pat-s opened this issue Nov 15, 2018 · 8 comments
Open
21 of 29 tasks

Missing filter / featsel methods #2

pat-s opened this issue Nov 15, 2018 · 8 comments

Comments

@pat-s
Copy link
Member

pat-s commented Nov 15, 2018

Filters

Pkg

No pkg

  • AUC

  • generic permutation

  • univariate.model.score

stats

  • anova

  • kruskal

  • linear.correlation

  • rank.correlation

  • variance

FSelector

Do we want to have these filters in again? Slow and Java problems..

FSelectorRcpp

  • information.gain
  • gain.ratio
  • symmetrical.uncertainty

Learner integrated filters

  • ranger.impurity

  • ranger.permutation

  • cforest.importance

Do we want to add the ramdomForest and randomForestSRC ones?

mRMRe

- [ ] mrmr -> slow and no support for classif tasks mlr-org/mlr#2604

praznik

  • CMIM

  • DISR

  • JMI

  • JMIM

  • MIM

  • MRMR

  • NJMIM

care

  • carscore

spFSR

Need to check.

Ensemble filters

  • Min

  • Mean

  • Median

  • Max

  • Borda

  • Borda-staircase

  • Borda-power

@mllg
Copy link
Sponsor Member

mllg commented Nov 16, 2018

For the filters: I'd start with stats / no pkg, then try to connect the modern filter packages (FSelectorRcpp and praznik).

We don't need 3 forest filters, we can solve this more generically by extending mlr3 learners with methods to extract feature scores.

@ja-thomas
Copy link

we can solve this more generically by extending mlr3 learners with methods to extract feature scores.

This is really important to be able to use all kinds of embedded feature selection directly by the learner.

@ja-thomas
Copy link

I don't really see a reason to use the Java FSelector package when there is FSelectoRcpp.

@pat-s
Copy link
Member Author

pat-s commented Nov 16, 2018

I don't really see a reason to use the Java FSelector package when there is FSelectoRcpp.

The later does not have all filters of the former. See https://mlr.mlr-org.com/articles/tutorial/filter_methods.html.

@ja-thomas
Copy link

Well, with this argument we have to include all possible filters 😄

I would suggest we start without it, and if people complain/open issues we can still add them later.
Or are there any really important filters not yet in FSelectorRcpp?

@berndbischl
Copy link
Sponsor Member

there never is (should be) pressure to include everything, include what is most important

@pat-s
Copy link
Member Author

pat-s commented Nov 16, 2018

My comment was more meant to be a comparison, not a statement that we should do it :)

@mllg
Copy link
Sponsor Member

mllg commented Apr 25, 2019

NB: All learners which have some sort of "importance" are now supported via FilterVariableImportance.

@pat-s pat-s added this to the v0.1 CRAN milestone Jun 6, 2019
@pat-s pat-s pinned this issue Jun 19, 2019
@pat-s pat-s removed this from the v0.1 CRAN milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants