Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterResult or Filter? #26

Closed
pat-s opened this issue Jun 6, 2019 · 3 comments
Closed

FilterResult or Filter? #26

pat-s opened this issue Jun 6, 2019 · 3 comments
Assignees
@pat-s @be-marc
Labels
Priority: Medium Status: Accepted Type: Enhancement

Comments

@pat-s
Copy link
Member

pat-s commented Jun 6, 2019

Following the logic of class mlr3::BenchmarkResult.

With public member functions .$get_best(), .$combine(), etc.
@pat-s pat-s mentioned this issue Jun 6, 2019
Closed
@pat-s
Copy link
Member Author

pat-s commented Jun 17, 2019

We should just rename Filter to FilterResult, and then add the respective member functions.

@pat-s
Copy link
Member Author

pat-s commented Jun 24, 2019

I am not so happy anymore with this change.
Since we have no dedicated "executer" like benchmark() or resample() which assigns its results to a result container ResampleResult, BenchmarkResult(), the current behavior of creating a new filter with the basic class FilterResult is not so intuitive.

Maybe we should stay with one R6 class Filter and just have everything in it.

@pat-s pat-s changed the title Implement class FilterResult FilterResult or Filter? Jun 24, 2019
@pat-s
Copy link
Member Author

pat-s commented Jul 27, 2019

"Filter".

@pat-s pat-s closed this as completed Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pat-s pat-s

@be-marc be-marc

Labels
Priority: Medium Status: Accepted Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pat-s @be-marc