Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass which.curve to PredictionSurv #334

Open
bblodfon opened this issue Oct 15, 2023 · 0 comments
Open

Pass which.curve to PredictionSurv #334

bblodfon opened this issue Oct 15, 2023 · 0 comments

Comments

@bblodfon
Copy link
Collaborator

Description

We cannot currently pass and store the which.curve parameter from a learner like BART into the PredictionSurv object. Currently, which.curve is just used to calculate the crank in .surv_return(). Therefore, all survival metrics or when combining predictions (via c.PredictionDataSurv) use the median curve (0.5).

TODOs

  1. pass the which.curve in PredictionSurv object somehow
  2. whenever we need to reduce the survival array to a matrix, an Arrdist via the p$distr field to a Matdist or convert with as.Distribution(...), we will extract the which.curve matrix, not the median
  3. combining a mix of survival arrays with matrices is now done by reducing the arrays to the median survival matrices but it should be the which.curve ones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant