Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check public methods of ParamSetTree #33

Closed
jakob-r opened this issue May 8, 2018 · 6 comments
Closed

Check public methods of ParamSetTree #33

jakob-r opened this issue May 8, 2018 · 6 comments
Labels

Comments

@jakob-r
Copy link
Sponsor Member

jakob-r commented May 8, 2018

Do we need the following to be public?

  • setRootHandle (it is not even used anywhere)
  • asample
  • asample.render2str (completely remove that)
  • getFlatList - i like the option to get a nested list, but this should then be sampleList and directly sample. Or is ist exactly what getRecursiveList() does?
@jakob-r jakob-r added the tree label May 8, 2018
@smilesun
Copy link
Contributor

I just checked, it it not possible currently to set asample to be private since asample need to call asample from another paramsetTree.

@smilesun
Copy link
Contributor

asample.render2str and setRootHandle has been removed

@smilesun
Copy link
Contributor

getFlatList and getRecursiveList() has been wrapped by sampleList()

@smilesun
Copy link
Contributor

getRecursiveList() and getFlatlist() can not be set to private since they need to call other objects same name method

@smilesun
Copy link
Contributor

smilesun commented Jun 7, 2018

@jakob-r , how do you think of the solution at branch tree2? I have put the funtionalities in 2 classes. ParamSetTree and ParamSetTreeX where in the latter I put functions you do not like and we do not expose them to the user?

@smilesun
Copy link
Contributor

smilesun commented Jun 7, 2018

@jakob-r , see latest commit Latest commit 143a2c4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants