Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParamSet: do we have an "add_param" method #49

Closed
berndbischl opened this issue Dec 1, 2018 · 5 comments
Closed

ParamSet: do we have an "add_param" method #49

berndbischl opened this issue Dec 1, 2018 · 5 comments

Comments

@berndbischl
Copy link
Sponsor Member

matthias has this in ConfigSpace, this might be more general then adding a full list of params in construction?
@jakob-r
Copy link
Sponsor Member

jakob-r commented Dec 11, 2018

we have the option to combine param sets. Should be enough?

I vote for closing this issue

@berndbischl
Copy link
Sponsor Member Author

no i really want this and this is necessary.
it is more the other way around. the constructor should either be empty or call that method, and combine should call this too

@berndbischl
Copy link
Sponsor Member Author

adding to a set is a really fundamental operation

@berndbischl
Copy link
Sponsor Member Author

should probably deep copy the param

@berndbischl
Copy link
Sponsor Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@berndbischl @jakob-r