Skip to content

Commit

Permalink
[Feature store] Change default targets path (#934)
Browse files Browse the repository at this point in the history
  • Loading branch information
dinal committed May 18, 2021
1 parent b4a981f commit 06bc642
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions mlrun/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@
},
"feature_store": {
"data_prefixes": {
"default": "v3io:///projects/{project}/fs/{kind}",
"nosql": "v3io:///projects/{project}/fs/{kind}",
"default": "v3io:///projects/{project}/FeatureStore/{name}/{kind}",
"nosql": "v3io:///projects/{project}/FeatureStore/{name}/{kind}",
},
"default_targets": "parquet,nosql",
"default_job_image": "mlrun/mlrun",
Expand Down
4 changes: 3 additions & 1 deletion mlrun/datastore/targets.py
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,9 @@ def _get_target_path(driver, resource):
name = resource.metadata.name
version = resource.metadata.tag
project = resource.metadata.project or mlrun.mlconf.default_project
data_prefix = get_default_prefix_for_target(kind).format(project=project, kind=kind)
data_prefix = get_default_prefix_for_target(kind).format(
project=project, kind=kind, name=name
)
# todo: handle ver tag changes, may need to copy files?
name = f"{name}-{version or 'latest'}"
return f"{data_prefix}/{kind_prefix}/{name}{suffix}"

0 comments on commit 06bc642

Please sign in to comment.