[Vault] Fix client to work when url is not configured (#859)

mlrun/api/api/endpoints/secrets.py

@@ -26,7 +26,10 @@ def initialize_project_secrets(
 
     # Init is idempotent and will do nothing if infra is already in place
     init_project_vault_configuration(project)
-    add_vault_project_secrets(project, secrets.secrets)
+
+    # If no secrets were passed, no need to touch the actual secrets.
+    if secrets.secrets:
+        add_vault_project_secrets(project, secrets.secrets)
     return Response(status_code=HTTPStatus.CREATED.value)
 
 

mlrun/projects/project.py

@@ -1233,7 +1233,7 @@ def get_vault_secrets(self, secrets=None, local=False):
             logger.warning(
                 "get_vault_secrets executed locally. This is not recommended and may become deprecated soon"
             )
-            self._secrets.vault.get_secrets(secrets, project=self.metadata.name)
+            return self._secrets.vault.get_secrets(secrets, project=self.metadata.name)
 
         run_db = get_run_db(secrets=self._secrets)
         project_secrets = run_db.get_project_secrets(

mlrun/utils/vault.py

@@ -147,6 +147,12 @@ def get_secrets(self, keys, user=None, project=None):
         secret_path = VaultStore._generate_path(user=user, project=project)
         secrets = {}
 
+        # Since this method is called both on the client side (when constructing VaultStore before persisting to
+        # pod configuration) and on server side and in execution pods, we let this method fail gracefully in this case.
+        # Should replace with something that will explode on server-side, once we have a way to do that.
+        if not self.url:
+            return secrets
+
         response = self._api_call("GET", secret_path)
 
         if not response: