Fix missing args when instantiating function from runtime (#488)

mlrun/run.py

@@ -457,6 +457,9 @@ def new_function(
 
     :return: function object
     """
+    # don't override given dict
+    if runtime and isinstance(runtime, dict):
+        runtime = deepcopy(runtime)
     kind, runtime = _process_runtime(command, runtime, kind)
     command = get_in(runtime, "spec.command", command)
     name = name or get_in(runtime, "metadata.name", "")
@@ -509,6 +512,9 @@ def _process_runtime(command, runtime, kind):
     if runtime and isinstance(runtime, dict):
         kind = kind or runtime.get("kind", "")
         command = command or get_in(runtime, "spec.command", "")
+        runtime_args = get_in(runtime, "spec.args", [])
+        if runtime_args:
+            command = f"{command} {' '.join(runtime_args)}"
     if "://" in command and command.startswith("http"):
         kind = kind or RuntimeKinds.remote
     if not runtime:

tests/runtimes/test_run.py

@@ -0,0 +1,34 @@
+from deepdiff import DeepDiff
+
+import mlrun
+
+
+def test_new_function_from_runtime():
+    runtime = {
+        "kind": "job",
+        "metadata": {
+            "name": "spark-submit",
+            "project": "default",
+            "categories": [],
+            "tag": "",
+            "hash": "7b3064c6b334535a5d949ebe9cfc61a094f98c78",
+            "updated": "2020-10-21T22:40:35.042132+00:00",
+        },
+        "spec": {
+            "command": "spark-submit",
+            "args": [
+                "--class",
+                "org.apache.spark.examples.SparkPi",
+                "/spark/examples/jars/spark-examples_2.11-2.4.4.jar",
+            ],
+            "image": "iguazio/shell:3.0_b5533_20201020062229",
+            "mode": "pass",
+            "volumes": [],
+            "volume_mounts": [],
+            "env": [],
+            "description": "",
+            "build": {"commands": []},
+        },
+    }
+    function = mlrun.new_function(runtime=runtime)
+    assert DeepDiff(runtime, function.to_dict(), ignore_order=True,) == {}