Skip to content

Commit

Permalink
[Requirements] Change fastapi to ~=0.67.0 to fix docs generation …
Browse files Browse the repository at this point in the history
…bug (#1377)
  • Loading branch information
Eyal Salomon committed Oct 3, 2021
1 parent 48013db commit 497327c
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
5 changes: 4 additions & 1 deletion requirements.txt
Expand Up @@ -55,7 +55,10 @@ kubernetes~=11.0
# TODO: move to API requirements (shouldn't really be here, the sql run db using the API sqldb is preventing us from
# separating the SDK and API code) (referring to humanfriendly and fastapi)
humanfriendly~=8.2
fastapi~=0.68.0
# fastapi fail to present docs. happen due to fastapi changes in 0.68.0
# the breaking PR is: https://github.com/tiangolo/fastapi/commit/97fa743ecb5a716fa0223a7463cb83f3f0df494c
# the bug report on: https://github.com/tiangolo/fastapi/issues/3782
fastapi~= 0.67.0
fsspec~=0.9.0
v3iofs~=0.1.7
# 3.4 and above failed builidng in some images - see https://github.com/pyca/cryptography/issues/5771
Expand Down
11 changes: 11 additions & 0 deletions tests/api/api/test_docs.py
@@ -0,0 +1,11 @@
import http

import fastapi.testclient
import sqlalchemy.orm


def test_docs(
db: sqlalchemy.orm.Session, client: fastapi.testclient.TestClient
) -> None:
response = client.get("/api/openapi.json")
assert response.status_code == http.HTTPStatus.OK.value

0 comments on commit 497327c

Please sign in to comment.