Skip to content

Commit

Permalink
[Projects] Support owner filter in follower mode (#1348)
Browse files Browse the repository at this point in the history
  • Loading branch information
Hedingber committed Sep 24, 2021
1 parent d51ab29 commit 536ecd4
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
4 changes: 2 additions & 2 deletions mlrun/api/utils/projects/follower.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,8 @@ def _filter_projects(
project for project in projects if project.metadata.name in names
]
if owner:
raise NotImplementedError(
"Filtering projects by owner is currently not supported in follower mode"
projects = list(
filter(lambda project: project.spec.owner == owner, projects)
)
if state:
projects = list(
Expand Down
9 changes: 8 additions & 1 deletion tests/api/utils/projects/test_follower_member.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,13 @@ def test_list_project(
projects_follower: mlrun.api.utils.projects.follower.Member,
nop_leader: mlrun.api.utils.projects.remotes.leader.Member,
):
project = _generate_project(name="name-1")
owner = "project-owner"
project = _generate_project(name="name-1", owner=owner)
archived_project = _generate_project(
name="name-2",
desired_state=mlrun.api.schemas.ProjectDesiredState.archived,
state=mlrun.api.schemas.ProjectState.archived,
owner=owner,
)
label_key = "key"
label_value = "value"
Expand Down Expand Up @@ -230,6 +232,11 @@ def test_list_project(
state=mlrun.api.schemas.ProjectState.archived,
)

# list by owner
_assert_list_projects(
projects_follower, [project, archived_project], owner=owner,
)

# list specific names only
_assert_list_projects(
projects_follower,
Expand Down

0 comments on commit 536ecd4

Please sign in to comment.