Fix chart artifact to have db key (#441)

mlrun · Sep 22, 2020 · 61b0c2c · 61b0c2c
1 parent 15bfc20
commit 61b0c2c
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 11 deletions.
diff --git a/mlrun/artifacts/plots.py b/mlrun/artifacts/plots.py
@@ -86,17 +86,6 @@ def get_body(self):
 
 class ChartArtifact(Artifact):
     kind = "chart"
-    _dict_fields = [
-        "key",
-        "kind",
-        "iter",
-        "tree",
-        "src_path",
-        "target_path",
-        "hash",
-        "description",
-        "viewer",
-    ]
 
     def __init__(
         self,

diff --git a/tests/artifacts/__init__.py b/tests/artifacts/__init__.py
diff --git a/tests/artifacts/test_artifacts.py b/tests/artifacts/test_artifacts.py
@@ -0,0 +1,22 @@
+import mlrun.artifacts
+
+
+def test_artifacts_export_required_fields():
+    artifact_classes = [
+        mlrun.artifacts.Artifact,
+        mlrun.artifacts.ChartArtifact,
+        mlrun.artifacts.PlotArtifact,
+        mlrun.artifacts.DatasetArtifact,
+        mlrun.artifacts.ModelArtifact,
+        mlrun.artifacts.TableArtifact,
+    ]
+
+    required_fields = [
+        "key",
+        "kind",
+        "db_key",
+    ]
+
+    for artifact_class in artifact_classes:
+        for required_field in required_fields:
+            assert required_field in artifact_class._dict_fields