[Alerts] Set criteria to defaults if not provided (#5796)

mlrun · Jun 23, 2024 · 65fd384 · 65fd384
1 parent f212bfb
commit 65fd384
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/mlrun/common/schemas/alert.py b/mlrun/common/schemas/alert.py
@@ -104,7 +104,7 @@ class AlertCriteria(pydantic.BaseModel):
         pydantic.Field(
             description="Number of events to wait until notification is sent"
         ),
-    ] = 0
+    ] = 1
     period: Annotated[
         str,
         pydantic.Field(

diff --git a/server/api/crud/alerts.py b/server/api/crud/alerts.py
@@ -45,6 +45,9 @@ def store_alert(
 
         self._validate_alert(alert_data, name, project)
 
+        if alert_data.criteria is None:
+            alert_data.criteria = mlrun.common.schemas.alert.AlertCriteria()
+
         if alert is not None:
             self._delete_notifications(alert)
         else:

diff --git a/tests/integration/sdk_api/alerts/test_alerts.py b/tests/integration/sdk_api/alerts/test_alerts.py
@@ -74,6 +74,8 @@ def test_alert_operations(self):
         # get alert and validate params
         alert = self._get_alerts(project_name, created_alert.name)
         self._validate_alert(alert, project_name, alert1["name"])
+        assert alert.criteria["count"] == 1
+        assert alert.criteria["period"] is None
 
         # try to get non existent alert ID
         with pytest.raises(mlrun.errors.MLRunNotFoundError):