Skip to content

Commit

Permalink
[Requirements] Remove protobuf requirement (#3617)
Browse files Browse the repository at this point in the history
  • Loading branch information
alonmr committed May 24, 2023
1 parent 008a22a commit 6bd0717
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion conda-arm64-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# with moving to arm64 for the new M1/M2 macs some packages are not yet compatible via pip and require
# conda which supports different architecture environments on the same machine
protobuf>=3.13, <3.20
lightgbm>=3.0
5 changes: 0 additions & 5 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ aiohttp~=3.8
aiohttp-retry~=2.8
# 8.1.0+ breaks dask/distributed versions older than 2022.04.0, see here - https://github.com/dask/distributed/pull/6018
click~=8.0.0
# when installing google-cloud-storage which required >=3.20.1, <5 it was upgrading the protobuf version to the latest
# version and because kfp 1.8.13 requires protobuf>=3.13, <4 it resulted incompatibility between kfp and protobuf
# this can be removed once kfp will support protobuf > 4
# since google-cloud blacklisted 3.20.0 and 3.20.1 we start from 3.20.2
protobuf>=3.13, <3.20
# 3.0/3.2 iguazio system uses 1.0.1, but we needed >=1.6.0 to be compatible with k8s>=12.0 to fix scurity issue
# since the sdk is still mark as beta (and not stable) I'm limiting to only patch changes
# 1.8.14 introduced new features related to ParallelFor, while our actual kfp server is 1.8.1, which isn't compatible
Expand Down
1 change: 0 additions & 1 deletion tests/test_requirements.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ def test_requirement_specifiers_convention():
"dask-ml": {"~=1.4,<1.9.0"},
"pyarrow": {">=10.0, <12"},
"nbclassic": {">=0.2.8"},
"protobuf": {">=3.13, <3.20"},
"pandas": {"~=1.2, <1.5.0"},
"ipython": {">=7.0, <9.0"},
"importlib_metadata": {">=3.6"},
Expand Down

0 comments on commit 6bd0717

Please sign in to comment.