[Cleanup] Fix crd objects cleanup (#592)

mlrun · Dec 15, 2020 · 92e5c84 · 92e5c84
1 parent 50cb450
commit 92e5c84
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/mlrun/runtimes/base.py b/mlrun/runtimes/base.py
@@ -22,7 +22,6 @@
 from os import environ
 from typing import Dict, List, Tuple, Union, Optional
 
-from kubernetes import client
 from kubernetes.client.rest import ApiException
 from sqlalchemy.orm import Session
 
@@ -1392,12 +1391,7 @@ def _delete_crd(namespace, crd_group, crd_version, crd_plural, crd_object):
         name = crd_object["metadata"]["name"]
         try:
             k8s_helper.crdapi.delete_namespaced_custom_object(
-                crd_group,
-                crd_version,
-                namespace,
-                crd_plural,
-                name,
-                client.V1DeleteOptions(),
+                crd_group, crd_version, namespace, crd_plural, name,
             )
             logger.info(
                 "Deleted crd object",

diff --git a/tests/api/runtime_handlers/base.py b/tests/api/runtime_handlers/base.py
@@ -200,7 +200,6 @@ def _assert_delete_namespaced_custom_objects(
                 expected_custom_object_namespace,
                 crd_plural,
                 expected_custom_object_name,
-                client.V1DeleteOptions(),
             )
             for expected_custom_object_name in expected_custom_object_names
         ]