Skip to content

Commit

Permalink
[Requirements] Bump nuclio-jupyter minimum to 0.8.14 (#947)
Browse files Browse the repository at this point in the history
  • Loading branch information
Hedingber committed May 24, 2021
1 parent 2a32410 commit d298905
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
9 changes: 9 additions & 0 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ twine~=3.1
black<=19.10b0
flake8~=3.8
pytest-asyncio~=0.14
# See jupyter-server requirement in nuclio-jupyter (https://github.com/nuclio/nuclio-jupyter/blob/master/Pipfile#L19)
# for why we're limiting it to a specific version and the relation to tornado
# The jupyter-server that we're using (1.0.8) has a bug (https://github.com/jupyter-server/jupyter_server/issues/337)
# which makes pytest dependent on pytest-tornasync (when jupyter-server is installed) the bug was fixed
# (https://github.com/jupyter-server/jupyter_server/pull/339) and released in 1.1.0
# (https://github.com/jupyter-server/jupyter_server/releases/tag/1.1.0) But the change there require tornado upgrade
# which we can't make currently
# TODO: when tornado upgrade is possible, upgrade jupyter-server and remove this
pytest-tornasync~=0.6.0
deepdiff~=5.0
pytest-alembic~=0.2
requests-mock~=1.8
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ kfp~=1.0.1
nest-asyncio~=1.0
# >=5.5 from nuclio-jupyter, <7.17 cause from 7.17 python 3.6 is not supported (and models-gpu-legacy image build fail)
ipython>=5.5, <7.17
nuclio-jupyter~=0.8.13
nuclio-jupyter~=0.8.14
# >=1.16.5 from pandas 1.2.1 and <1.20.0 because we're hitting the same issue as this one
# https://github.com/Azure/MachineLearningNotebooks/issues/1314
numpy>=1.16.5, <1.20.0
Expand Down

0 comments on commit d298905

Please sign in to comment.