Skip to content

Commit

Permalink
[Requirements] Bump scikit-learn to 1.x (#1481)
Browse files Browse the repository at this point in the history
  • Loading branch information
Hedingber committed Nov 9, 2021
1 parent a504fe6 commit d33b993
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 4 deletions.
3 changes: 2 additions & 1 deletion dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ graphviz~=0.16.0
nuclio-sdk~=0.3.0
isort~=5.7
# needed for mlutils tests
scikit-learn~=0.23.0
scikit-learn~=1.0; python_version >= '3.7'
scikit-learn~=0.23.0; python_version < '3.7'
3 changes: 2 additions & 1 deletion dockerfiles/jupyter/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
matplotlib~=3.0
scipy~=1.0
scikit-learn~=0.23.0
scikit-learn~=1.0; python_version >= '3.7'
scikit-learn~=0.23.0; python_version < '3.7'
seaborn~=0.11.0
scikit-plot~=0.3.7
xgboost~=1.1
Expand Down
3 changes: 2 additions & 1 deletion dockerfiles/mlrun/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
matplotlib~=3.0
scipy~=1.0
scikit-learn~=0.23.0
scikit-learn~=1.0; python_version >= '3.7'
scikit-learn~=0.23.0; python_version < '3.7'
seaborn~=0.11.0
scikit-plot~=0.3.7
3 changes: 2 additions & 1 deletion dockerfiles/test-system/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
pytest~=5.4
matplotlib~=3.0
graphviz~=0.16.0
scikit-learn~=0.23.0
scikit-learn~=1.0; python_version >= '3.7'
scikit-learn~=0.23.0; python_version < '3.7'
4 changes: 4 additions & 0 deletions tests/test_requirements.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ def test_requirement_specifiers_inconsistencies():
ignored_inconsistencies_map = {
# It's ok we have 2 different versions cause they are for different python versions
"pandas": {"~=1.2; python_version >= '3.7'", "~=1.0; python_version < '3.7'"},
"scikit-learn": {
"~=1.0; python_version >= '3.7'",
"~=0.23.0; python_version < '3.7'",
},
# The empty specifier is from tests/runtimes/assets/requirements.txt which is there specifically to test the
# scenario of requirements without version specifiers
"python-dotenv": {"", "~=0.17.0"},
Expand Down

0 comments on commit d33b993

Please sign in to comment.