[Artifacts] Fix store url generation (#643)

mlrun · Jan 11, 2021 · df85ac3 · df85ac3
1 parent 28a6201
commit df85ac3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/mlrun/utils/helpers.py b/mlrun/utils/helpers.py
@@ -76,7 +76,7 @@ def is_prefix(cls, prefix):
 def get_artifact_target(item: dict, project=None):
     kind = item.get("kind")
     if kind in ["dataset", "model"] and item.get("db_key"):
-        return "{}://{}/{}/{}#{}".format(
+        return "{}://{}/{}/{}:{}".format(
             DB_SCHEMA,
             StorePrefix.Artifact,
             project or item.get("project"),

diff --git a/tests/system/base.py b/tests/system/base.py
@@ -200,7 +200,7 @@ def _verify_run_outputs(
         assert run_outputs["model"] == str(output_path / iterpath / "model.txt")
         assert run_outputs["html_result"] == str(output_path / iterpath / "result.html")
         assert run_outputs["chart"] == str(output_path / iterpath / "chart.html")
-        assert run_outputs["mydf"] == f"store://{project}/{name}_mydf#{uid}"
+        assert run_outputs["mydf"] == f"store://artifacts/{project}/{name}_mydf:{uid}"
         if accuracy:
             assert run_outputs["accuracy"] == accuracy
         if loss:

diff --git a/tests/system/examples/jobs/test_jobs.py b/tests/system/examples/jobs/test_jobs.py
@@ -124,7 +124,7 @@ def job_pipeline(p1: int = 9) -> None:
             outputs=["validation", "run_id"],
             output_path=f"v3io:///users/admin/kfp/{workflow_run_id}/",
             inputs={
-                "model": f"store://{self.project_name}/my-trainer-training_mymodel#{workflow_run_id}",
+                "model": f"store://artifacts/{self.project_name}/my-trainer-training_mymodel:{workflow_run_id}",
             },
             data_stores=[],
         )